On 06/24/2014 03:20 AM, Ian Campbell wrote:
>
> I see VIR_STRDUP actually does handle NULL input correctly, which was
> what I was worried about.
Yes, it is by design that VIR_STRDUP(NULL) works, and gives a different
return value (0) than when dup'ing a string (positive) or on failure
(negative)
On Thu, 2014-06-19 at 00:15 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
> >
> >> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
> >>
> >
> > This was subtly broken. The default needs to be "".
> >
>
> Tur
Ian Campbell wrote:
> On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
>
>> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
>>
>
> This was subtly broken. The default needs to be "".
>
Turns out, it wasn't :). Prior to this patch, def->os.cmdline was set
to NU
Eric Blake wrote:
> On 06/18/2014 11:46 AM, Jim Fehlig wrote:
>
>
>>> In addition to extra= xm supported a root= option which was supposed
>>> to be incorporated into the final command line. Handle that for "virsh
>>> domxml-from-native xen-xm". Tested with the libxl backend.
>>>
>>> Signed-off-
On 06/18/2014 11:46 AM, Jim Fehlig wrote:
>>
>> In addition to extra= xm supported a root= option which was supposed
>> to be incorporated into the final command line. Handle that for "virsh
>> domxml-from-native xen-xm". Tested with the libxl backend.
>>
>> Signed-off-by: Ian Campbell
>> ---
>>
Ian Campbell wrote:
> On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
>
>> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
>>
>
> This was subtly broken. The default needs to be "".
>
> -8<--
>
> >From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00
On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote:
> +if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0)
This was subtly broken. The default needs to be "".
-8<--
>From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00:00:00 2001
From: Ian Campbell
Date: Tue, 17
Eric Blake wrote:
> On 06/17/2014 09:24 AM, Ian Campbell wrote:
>
>> In addition to extra= xm supported a root= option which was supposed
>> to be incorporated into the final command line. Handle that for "virsh
>> domxml-from-native xen-xm". Tested with the libxl backend.
>>
>> Signed-off-by: I
On 06/17/2014 09:24 AM, Ian Campbell wrote:
> In addition to extra= xm supported a root= option which was supposed
> to be incorporated into the final command line. Handle that for "virsh
> domxml-from-native xen-xm". Tested with the libxl backend.
>
> Signed-off-by: Ian Campbell
> ---
> .gnulib
In addition to extra= xm supported a root= option which was supposed
to be incorporated into the final command line. Handle that for "virsh
domxml-from-native xen-xm". Tested with the libxl backend.
Signed-off-by: Ian Campbell
---
.gnulib|2 +-
src/xenxs/xen_xm.c | 14 +
10 matches
Mail list logo
