Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-08 Thread Edgar Kaziakhmedov
On 02/07/2018 03:26 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 03:23:58PM +0300, Edgar Kaziakhmedov wrote: On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-07 Thread Edgar Kaziakhmedov
On 02/07/2018 03:26 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 03:23:58PM +0300, Edgar Kaziakhmedov wrote: On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-07 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 03:23:58PM +0300, Edgar Kaziakhmedov wrote: > > > On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: > > > Ping > > > > > > > > > On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: > > > > PyInt_Check

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-07 Thread Edgar Kaziakhmedov
On 02/07/2018 01:56 PM, Daniel P. Berrangé wrote: On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: PyInt_Check returns value whether or not an input object is the integer type. The existing implementation of extractin

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-07 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 01:46:00PM +0300, Edgar Kaziakhmedov wrote: > Ping > > > On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: > > PyInt_Check returns value whether or not an input object is the integer > > type. The existing implementation of extracting leads to the wrong > > type interpreta

Re: [libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-02-07 Thread Edgar Kaziakhmedov
Ping On 01/31/2018 07:34 PM, Edgar Kaziakhmedov wrote: PyInt_Check returns value whether or not an input object is the integer type. The existing implementation of extracting leads to the wrong type interpretation in the following code: params = {libvirt.VIR_MIGRATE_PARAM_DISKS_PORT : 50123} .

[libvirt] [PATCH python 1/1] Fix type extracting from PyDict

2018-01-31 Thread Edgar Kaziakhmedov
PyInt_Check returns value whether or not an input object is the integer type. The existing implementation of extracting leads to the wrong type interpretation in the following code: params = {libvirt.VIR_MIGRATE_PARAM_DISKS_PORT : 50123} ... dom.migrate3(%option1, params, %option3) where libvirt