Re: [libvirt] [PATCH v1 04/32] util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

2018-08-05 Thread Andrea Bolognani
On Fri, 2018-08-03 at 09:51 +0200, Erik Skultety wrote: > > > > +void > > > > +virMacAddrFree(virMacAddrPtr addr) > > > > +{ > > > > +VIR_FREE(addr); > > > > +} > > > > > > I understand the reason behind this change, however, I don't feel like > > > this > > > will bring any benefits only

Re: [libvirt] [PATCH v1 04/32] util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

2018-08-05 Thread Erik Skultety
On Fri, Aug 03, 2018 at 09:34:51AM +0200, Erik Skultety wrote: > On Fri, Aug 03, 2018 at 09:30:22AM +0200, Erik Skultety wrote: > > On Sat, Jul 28, 2018 at 11:31:19PM +0530, Sukrit Bhatnagar wrote: > > > Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in > > > src/util/viralloc.h, define a new

Re: [libvirt] [PATCH v1 04/32] util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

2018-08-05 Thread Erik Skultety
On Sat, Jul 28, 2018 at 11:31:19PM +0530, Sukrit Bhatnagar wrote: > Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in > src/util/viralloc.h, define a new wrapper around an existing > cleanup function which will be called when a variable declared > with VIR_AUTOPTR macro goes out of scope.

Re: [libvirt] [PATCH v1 04/32] util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

2018-08-03 Thread Erik Skultety
On Fri, Aug 03, 2018 at 09:30:22AM +0200, Erik Skultety wrote: > On Sat, Jul 28, 2018 at 11:31:19PM +0530, Sukrit Bhatnagar wrote: > > Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in > > src/util/viralloc.h, define a new wrapper around an existing > > cleanup function which will be called

[libvirt] [PATCH v1 04/32] util: macaddr: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

2018-07-28 Thread Sukrit Bhatnagar
Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in src/util/viralloc.h, define a new wrapper around an existing cleanup function which will be called when a variable declared with VIR_AUTOPTR macro goes out of scope. Also, drop the redundant viralloc.h include, since that has moved from the