Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-12 Thread Michal Privoznik
On 11/9/19 1:12 AM, Jonathon Jongsma wrote: Thanks for the thorough review Michal, clearly it needs more work. In particular, I was not yet aware of the private xml save/restore stuff. Thanks for the pointers in that regard. But I have one particular question below: On Fri, 2019-11-08 at 11:46

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Jonathon Jongsma
Thanks for the thorough review Michal, clearly it needs more work. In particular, I was not yet aware of the private xml save/restore stuff. Thanks for the pointers in that regard. But I have one particular question below: On Fri, 2019-11-08 at 11:46 +0100, Michal Privoznik wrote: > 1: It's not

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Daniel P . Berrangé
On Wed, Nov 06, 2019 at 03:13:21PM -0600, Jonathon Jongsma wrote: > Some layered products such as oVirt have requested a way to avoid being > blocked by guest agent commands when querying a loaded vm. For example, > many guest agent commands are polled periodically to monitor changes, > and rather

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-08 Thread Michal Privoznik
On 11/6/19 10:13 PM, Jonathon Jongsma wrote: Some layered products such as oVirt have requested a way to avoid being blocked by guest agent commands when querying a loaded vm. For example, many guest agent commands are polled periodically to monitor changes, and rather than blocking the calling

Re: [libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-06 Thread Jonathon Jongsma
Unfortunately, I sent this patch out a bit prematurely. I forgot to run syntax-check after adding the 'flags' argument, so there are a few minor changes required for that. I also forgot to update the version references (should be 5.10 now since 5.9 was just released). But I'll wait to send an

[libvirt] [PATCH v2] Add API to change qemu agent response timeout

2019-11-06 Thread Jonathon Jongsma
Some layered products such as oVirt have requested a way to avoid being blocked by guest agent commands when querying a loaded vm. For example, many guest agent commands are polled periodically to monitor changes, and rather than blocking the calling process, they'd prefer to simply time out when