Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Martin Kletzander
On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: V2: Addressed comments raised in review of V1. Consolidate calls to virNetDevBandwidthSet. Clear bandwidth settings when the interface is detached or domain destroyed. V1: Ethernet interfaces in libvirt currently do not

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Anirban Chakraborty
On 10/5/14, 11:07 PM, Martin Kletzander mklet...@redhat.com wrote: On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: V2: Addressed comments raised in review of V1. Consolidate calls to virNetDevBandwidthSet. Clear bandwidth settings when the interface is detached or domain

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Laine Stump
On 10/06/2014 02:07 AM, Martin Kletzander wrote: On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: V2: Addressed comments raised in review of V1. Consolidate calls to virNetDevBandwidthSet. Clear bandwidth settings when the interface is detached or domain destroyed. V1:

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-06 Thread Anirban Chakraborty
On 10/6/14, 11:16 AM, Laine Stump la...@laine.org wrote: On 10/06/2014 02:07 AM, Martin Kletzander wrote: On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote: V2: Addressed comments raised in review of V1. Consolidate calls to virNetDevBandwidthSet. Clear bandwidth settings

Re: [libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-10-01 Thread Anirban Chakraborty
Should I recreate this patch on the top of the latest tree and resubmit? Or, is there anything that I missed out? Any feedback will be highly appreciated. Thanks. Anirban On 9/26/14, 10:52 AM, Anirban Chakraborty abc...@juniper.net wrote: V2: Addressed comments raised in review of V1.

[libvirt] [PATCH v2] network: Add network bandwidth support for ethernet interfaces

2014-09-26 Thread Anirban Chakraborty
V2: Addressed comments raised in review of V1. Consolidate calls to virNetDevBandwidthSet. Clear bandwidth settings when the interface is detached or domain destroyed. V1: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface