Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-13 Thread Peter Krempa
On Thu, Mar 12, 2015 at 14:23:48 -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1199182 documents that after a series of disk snapshots into existing destination images, followed by active commits of the top image, it is possible for qemu 2.2 and earlier to end up

Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-13 Thread Eric Blake
On 03/13/2015 02:02 AM, Peter Krempa wrote: @@ -16172,8 +16169,12 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm, } qemuDomainObjEnterMonitor(driver, vm); -ret = qemuMonitorBlockJob(priv-mon, device, basePath, backingPath, - speed, mode, async); +

Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-13 Thread Daniel P. Berrange
On Fri, Mar 13, 2015 at 07:01:06AM -0600, Eric Blake wrote: On 03/13/2015 02:02 AM, Peter Krempa wrote: @@ -16172,8 +16169,12 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm, } qemuDomainObjEnterMonitor(driver, vm); -ret = qemuMonitorBlockJob(priv-mon, device, basePath,

Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-12 Thread Shanzhi Yu
I do meet libvirtd crash sometime when test this patch(I also met it when test v1 yesterday, but can not reproduce it 100%.) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffe9d39700 (LWP 25413)] virJSONValueObjectGetString (object=0x0, key=key@entry=0x7fffe4f72429

[libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-12 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=1199182 documents that after a series of disk snapshots into existing destination images, followed by active commits of the top image, it is possible for qemu 2.2 and earlier to end up tracking a different name for the image than what it would have had