Re: [libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

2015-03-04 Thread Shanzhi Yu
On 03/04/2015 09:12 PM, Peter Krempa wrote: > On Sat, Feb 28, 2015 at 17:51:36 +0800, Shanzhi Yu wrote: >> When the domain's source disk type is network, if source protocol >> is rbd or sheepdog, the 'if().. break' will end the current case, >> which lead to miss check the driver type is raw or q

Re: [libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

2015-03-04 Thread Peter Krempa
On Sat, Feb 28, 2015 at 17:51:36 +0800, Shanzhi Yu wrote: > When the domain's source disk type is network, if source protocol > is rbd or sheepdog, the 'if().. break' will end the current case, > which lead to miss check the driver type is raw or qcow2. Libvirt > will allow to create internal snaps

[libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

2015-02-28 Thread Shanzhi Yu
When the domain's source disk type is network, if source protocol is rbd or sheepdog, the 'if().. break' will end the current case, which lead to miss check the driver type is raw or qcow2. Libvirt will allow to create internal snapshot for a running domain with raw format disk which based on rbd s