Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

2016-09-22 Thread Chen Hanxiao
At 2016-09-22 19:05:33, "John Ferlan" wrote: > >>> >>> BTW: Patch 2 fails syntax-check >>> >> >> I make syntax-check again and passed on a centos7 machine. >> Maybe it's a syntax-check bug? >> > >Don't think so... > > >cppi: src/qemu/qemu_driver.c: line 3269: not properly

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

2016-09-22 Thread John Ferlan
>> >> BTW: Patch 2 fails syntax-check >> > > I make syntax-check again and passed on a centos7 machine. > Maybe it's a syntax-check bug? > Don't think so... cppi: src/qemu/qemu_driver.c: line 3269: not properly indented maint.mk: incorrect preprocessor indentation cfg.mk:680: recipe for

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

2016-09-21 Thread Chen Hanxiao
At 2016-09-22 05:32:10, "John Ferlan" wrote: > > >On 09/19/2016 07:06 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This series will pass the path of compress programe >> directly to functions such as doCoreDump, qemuDomainSaveInternal, etc. >>

Re: [libvirt] [PATCH v2 0/3] pass the path of compress prog directly

2016-09-21 Thread John Ferlan
On 09/19/2016 07:06 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This series will pass the path of compress programe > directly to functions such as doCoreDump, qemuDomainSaveInternal, etc. > this can avoid one extra virFindFileInPath call in during virExec. > >

[libvirt] [PATCH v2 0/3] pass the path of compress prog directly

2016-09-19 Thread Chen Hanxiao
From: Chen Hanxiao This series will pass the path of compress programe directly to functions such as doCoreDump, qemuDomainSaveInternal, etc. this can avoid one extra virFindFileInPath call in during virExec. Also reduce code duplication by macros. Chen Hanxiao (3):