[...]
>>> For the general nosuid, nodev flags, I think we can do something like we
>>> have for the element in the domain XML.
>>>
>>
>> So that means to me that every option currently possible in mount would
>> need to be listed. Doesn't that feel excessive? Not that mount changes
>> that
On Wed, Jan 09, 2019 at 01:26:19PM -0500, John Ferlan wrote:
>
>
> On 1/9/19 12:40 PM, Daniel P. Berrangé wrote:
> > On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
> >>
> >>
> >> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> >>> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John
On 1/9/19 12:40 PM, Daniel P. Berrangé wrote:
> On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
>>
>>
>> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
>>> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
v1:
On 1/9/19 11:55 AM, Michal Privoznik wrote:
[...]
>
>
> ACK
>
Thanks for the review... although it seems I'll have to consider a 3rd
approach as a result of Daniel's comments. Nothing is ever easy.
> My only worry is that we don't validate the options in any way. They are
> basically a
On Wed, Jan 09, 2019 at 12:31:02PM -0500, John Ferlan wrote:
>
>
> On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> > On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
> >> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
> >>
> >> Kept the subject the same,
On 1/9/19 12:09 PM, Daniel P. Berrangé wrote:
> On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
>> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>>
>> Kept the subject the same, but the concept has been adjusted to follow
>> issues pointed out by jtomko
On Tue, Jan 08, 2019 at 12:52:20PM -0500, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>
> Kept the subject the same, but the concept has been adjusted to follow
> issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML.
> This
On 1/8/19 6:52 PM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
>
> Kept the subject the same, but the concept has been adjusted to follow
> issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML.
> This series adds both the
v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00558.html
Kept the subject the same, but the concept has been adjusted to follow
issues pointed out by jtomko vis-a-vis allowing arbitrary options via XML.
This series adds both the NFS and the RBD adjustments that were essentially
