Re: [libvirt] [PATCH v2 01/14] qemuBuildMemoryBackendStr: Reorder args and update comment

2017-03-09 Thread Michal Privoznik
On 03/07/2017 05:00 PM, John Ferlan wrote: > > > On 02/27/2017 08:19 AM, Michal Privoznik wrote: >> Frankly, this function is one big mess. A lot of arguments, >> complicated behaviour. It's really surprising that arguments were >> in random order (input and output arguments were mixed

Re: [libvirt] [PATCH v2 01/14] qemuBuildMemoryBackendStr: Reorder args and update comment

2017-03-07 Thread John Ferlan
On 02/27/2017 08:19 AM, Michal Privoznik wrote: > Frankly, this function is one big mess. A lot of arguments, > complicated behaviour. It's really surprising that arguments were > in random order (input and output arguments were mixed together), > the documentation was outdated, the description

[libvirt] [PATCH v2 01/14] qemuBuildMemoryBackendStr: Reorder args and update comment

2017-02-27 Thread Michal Privoznik
Frankly, this function is one big mess. A lot of arguments, complicated behaviour. It's really surprising that arguments were in random order (input and output arguments were mixed together), the documentation was outdated, the description of return values was bogus. Signed-off-by: Michal