Re: [libvirt] [PATCH v2 04/15] vbox: vboxAttachDrives now relies on address info

2017-11-03 Thread John Ferlan
On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > Previously, the driver was computing VBOX's devicePort/deviceSlot values > based on device name and max port/slot values. While this worked, it > completely ignored values. Additionally, libvirt's built-in > virDomainDiskDefAssignAddress already do

[libvirt] [PATCH v2 04/15] vbox: vboxAttachDrives now relies on address info

2017-10-24 Thread Dawid Zamirski
Previously, the driver was computing VBOX's devicePort/deviceSlot values based on device name and max port/slot values. While this worked, it completely ignored values. Additionally, libvirt's built-in virDomainDiskDefAssignAddress already does a good job setting default values on virDomainDevice