Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-24 Thread Michal Privoznik
On 07/24/2018 04:08 PM, John Ferlan wrote: > > > Reading something like: > > /* mocking real environment output is not feasible for [creating | > updating | logging into], example of real environment is: > > xxx > > */ > > I believe is better - it's not difficult to add, but I'm at the poin

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-24 Thread John Ferlan
On 07/24/2018 04:25 AM, Michal Privoznik wrote: > On 07/23/2018 03:55 PM, John Ferlan wrote: >> >> >> On 07/23/2018 08:34 AM, Michal Prívozník wrote: >>> On 07/23/2018 02:12 PM, John Ferlan wrote: On 07/23/2018 04:01 AM, Michal Prívozník wrote: > On 07/17/2018 09:14 PM, John Fe

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-24 Thread Michal Privoznik
On 07/23/2018 03:55 PM, John Ferlan wrote: > > > On 07/23/2018 08:34 AM, Michal Prívozník wrote: >> On 07/23/2018 02:12 PM, John Ferlan wrote: >>> >>> >>> On 07/23/2018 04:01 AM, Michal Prívozník wrote: On 07/17/2018 09:14 PM, John Ferlan wrote: > > > On 07/04/2018 05:23 AM, Mich

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-23 Thread John Ferlan
On 07/23/2018 08:34 AM, Michal Prívozník wrote: > On 07/23/2018 02:12 PM, John Ferlan wrote: >> >> >> On 07/23/2018 04:01 AM, Michal Prívozník wrote: >>> On 07/17/2018 09:14 PM, John Ferlan wrote: On 07/04/2018 05:23 AM, Michal Privoznik wrote: > Introduce one basic test that t

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-23 Thread Michal Prívozník
On 07/23/2018 02:12 PM, John Ferlan wrote: > > > On 07/23/2018 04:01 AM, Michal Prívozník wrote: >> On 07/17/2018 09:14 PM, John Ferlan wrote: >>> >>> >>> On 07/04/2018 05:23 AM, Michal Privoznik wrote: Introduce one basic test that tests the simplest case: logging into portal without a

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-23 Thread John Ferlan
On 07/23/2018 04:01 AM, Michal Prívozník wrote: > On 07/17/2018 09:14 PM, John Ferlan wrote: >> >> >> On 07/04/2018 05:23 AM, Michal Privoznik wrote: >>> Introduce one basic test that tests the simplest case: >>> logging into portal without any IQN. >>> >>> Signed-off-by: Michal Privoznik >>> --

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-23 Thread Michal Prívozník
On 07/17/2018 09:14 PM, John Ferlan wrote: > > > On 07/04/2018 05:23 AM, Michal Privoznik wrote: >> Introduce one basic test that tests the simplest case: >> logging into portal without any IQN. >> >> Signed-off-by: Michal Privoznik >> --- >> tests/viriscsitest.c | 46 ++

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-23 Thread Michal Prívozník
On 07/17/2018 08:46 PM, John Ferlan wrote: > > > On 07/04/2018 05:23 AM, Michal Privoznik wrote: >> Introduce one basic test that tests the simplest case: >> logging into portal without any IQN. >> >> Signed-off-by: Michal Privoznik >> --- >> tests/viriscsitest.c | 46 ++

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-17 Thread John Ferlan
On 07/04/2018 05:23 AM, Michal Privoznik wrote: > Introduce one basic test that tests the simplest case: > logging into portal without any IQN. > > Signed-off-by: Michal Privoznik > --- > tests/viriscsitest.c | 46 ++ > 1 file changed, 46 insertions

Re: [libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-17 Thread John Ferlan
On 07/04/2018 05:23 AM, Michal Privoznik wrote: > Introduce one basic test that tests the simplest case: > logging into portal without any IQN. > > Signed-off-by: Michal Privoznik > --- > tests/viriscsitest.c | 46 ++ > 1 file changed, 46 insertions

[libvirt] [PATCH v2 07/10] viriscsitest: Test virISCSIConnectionLogin

2018-07-04 Thread Michal Privoznik
Introduce one basic test that tests the simplest case: logging into portal without any IQN. Signed-off-by: Michal Privoznik --- tests/viriscsitest.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/tests/viriscsitest.c b/tests/viriscsitest.c ind