Re: [libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

2018-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 07:14:26AM -0500, John Ferlan wrote: > > > On 02/01/2018 06:57 AM, John Ferlan wrote: > > > > > > On 01/23/2018 08:23 AM, Daniel P. Berrange wrote: > >> The server name and client data callbacks need to be non-NULL or the > >> system will crash at various times. This is

Re: [libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

2018-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 06:57:49AM -0500, John Ferlan wrote: > > > On 01/23/2018 08:23 AM, Daniel P. Berrange wrote: > > The server name and client data callbacks need to be non-NULL or the > > system will crash at various times. This is particularly bad when some > > of the crashes only occur

Re: [libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

2018-02-01 Thread John Ferlan
On 02/01/2018 06:57 AM, John Ferlan wrote: > > > On 01/23/2018 08:23 AM, Daniel P. Berrange wrote: >> The server name and client data callbacks need to be non-NULL or the >> system will crash at various times. This is particularly bad when some >> of the crashes only occur post-exec restart.

Re: [libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

2018-02-01 Thread John Ferlan
On 01/23/2018 08:23 AM, Daniel P. Berrange wrote: > The server name and client data callbacks need to be non-NULL or the > system will crash at various times. This is particularly bad when some > of the crashes only occur post-exec restart. > > Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

2018-01-23 Thread Daniel P. Berrange
The server name and client data callbacks need to be non-NULL or the system will crash at various times. This is particularly bad when some of the crashes only occur post-exec restart. Signed-off-by: Daniel P. Berrange --- src/rpc/virnetserver.h | 7 +--