Re: [libvirt] [PATCH v2 1/3] vbox: Remove old unflexible macros

2017-10-25 Thread John Ferlan
On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > The VBOX_SESSION_OPEN/CLOSE macros are only called in > _vboxDomainSnapshotRestore and they are unflexible because: > > * assume the caller will have variable named "data" > * can only create Write lock type > > As per above, it's not that hard

[libvirt] [PATCH v2 1/3] vbox: Remove old unflexible macros

2017-10-24 Thread Dawid Zamirski
The VBOX_SESSION_OPEN/CLOSE macros are only called in _vboxDomainSnapshotRestore and they are unflexible because: * assume the caller will have variable named "data" * can only create Write lock type As per above, it's not that hard to simply use the VBOX API directly. --- src/vbox/vbox_tmpl.c