Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Erik Skultety
On Fri, Aug 16, 2019 at 05:57:36PM +0300, Ilias Stamatis wrote: > On Fri, Aug 16, 2019 at 5:39 PM Erik Skultety wrote: > > > > ... > > > > > + > > > +if (operation == TEST_DEVICE_DETACH) > > > +parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE; > > > > ^This should be added by patch 3/

Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Ilias Stamatis
On Fri, Aug 16, 2019 at 5:39 PM Erik Skultety wrote: > > ... > > > + > > +if (operation == TEST_DEVICE_DETACH) > > +parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE; > > ^This should be added by patch 3/5 > > > + > > +if (xml) { > > +if (!(dev = virDomainDeviceDefParse(xml

Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Erik Skultety
... > + > +if (operation == TEST_DEVICE_DETACH) > +parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE; ^This should be added by patch 3/5 > + > +if (xml) { > +if (!(dev = virDomainDeviceDefParse(xml, def, > +driver->caps, driver-

[libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 290 + 1 file changed, 290 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c39eef2d4b..5f28e9017f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @