Re: [libvirt] [PATCH v2 1/7] configure: change HAVE_FIREWALLD to WITH_FIREWALLD

2019-02-01 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 08:24:52PM -0500, Laine Stump wrote: > Support for firewalld is a feature that can be selectively enabled or > disabled (using --with-firewalld/--without-firewalld), not merely > something that must be accounted for in the code if it is present with > no exceptions. It is

[libvirt] [PATCH v2 1/7] configure: change HAVE_FIREWALLD to WITH_FIREWALLD

2019-01-31 Thread Laine Stump
Support for firewalld is a feature that can be selectively enabled or disabled (using --with-firewalld/--without-firewalld), not merely something that must be accounted for in the code if it is present with no exceptions. It is more consistent with other usage in libvirt to use WITH_FIREWALLD