Re: [libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-24 Thread John Ferlan
On 07/24/2018 05:48 AM, Michal Privoznik wrote: > On 07/23/2018 03:10 PM, John Ferlan wrote: >> >> >> On 07/23/2018 04:01 AM, Michal Prívozník wrote: >>> On 07/17/2018 09:15 PM, John Ferlan wrote: On 07/04/2018 05:23 AM, Michal Privoznik wrote: > Extend this existing test so th

Re: [libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-24 Thread Michal Privoznik
On 07/23/2018 03:10 PM, John Ferlan wrote: > > > On 07/23/2018 04:01 AM, Michal Prívozník wrote: >> On 07/17/2018 09:15 PM, John Ferlan wrote: >>> >>> >>> On 07/04/2018 05:23 AM, Michal Privoznik wrote: Extend this existing test so that a case when IQN is provided is tested too. Since a

Re: [libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-23 Thread John Ferlan
On 07/23/2018 04:01 AM, Michal Prívozník wrote: > On 07/17/2018 09:15 PM, John Ferlan wrote: >> >> >> On 07/04/2018 05:23 AM, Michal Privoznik wrote: >>> Extend this existing test so that a case when IQN is provided is >>> tested too. Since a special iSCSI interface is created and its >>> name is

Re: [libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-23 Thread Michal Prívozník
On 07/17/2018 09:15 PM, John Ferlan wrote: > > > On 07/04/2018 05:23 AM, Michal Privoznik wrote: >> Extend this existing test so that a case when IQN is provided is >> tested too. Since a special iSCSI interface is created and its >> name is randomly generated at runtime we need to link with >> v

Re: [libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-17 Thread John Ferlan
On 07/04/2018 05:23 AM, Michal Privoznik wrote: > Extend this existing test so that a case when IQN is provided is > tested too. Since a special iSCSI interface is created and its > name is randomly generated at runtime we need to link with > virrandommock to have predictable names. > > Signed-

[libvirt] [PATCH v2 10/10] viriscsitest: Extend virISCSIConnectionLogin test

2018-07-04 Thread Michal Privoznik
Extend this existing test so that a case when IQN is provided is tested too. Since a special iSCSI interface is created and its name is randomly generated at runtime we need to link with virrandommock to have predictable names. Signed-off-by: Michal Privoznik --- tests/viriscsitest.c | 75 ++