Re: [libvirt] [PATCH v2 12/15] vbox: Correctly generate drive name in dumpxml

2017-11-07 Thread Dawid Zamirski
On Fri, 2017-11-03 at 09:52 -0400, John Ferlan wrote: > > On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > > If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML > > generated > > by dumpxml used to produce "sda" for both of those disks. This is > > an > > invalid domain XML as libvirt does

Re: [libvirt] [PATCH v2 12/15] vbox: Correctly generate drive name in dumpxml

2017-11-03 Thread John Ferlan
On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated > by dumpxml used to produce "sda" for both of those disks. This is an > invalid domain XML as libvirt does not allow duplicate device names. To > address this, keep the running

[libvirt] [PATCH v2 12/15] vbox: Correctly generate drive name in dumpxml

2017-10-24 Thread Dawid Zamirski
If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated by dumpxml used to produce "sda" for both of those disks. This is an invalid domain XML as libvirt does not allow duplicate device names. To address this, keep the running total of disks that will use "sd" prefix for device name