Re: [libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-08-04 Thread Ján Tomko
On Mon, Aug 03, 2015 at 11:27:56PM +0530, madhu pavan wrote: > > > On 08/03/2015 06:23 PM, Ján Tomko wrote: > > On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote: > >> PowerPC pseries based VMs do not support a floppy disk controller. > > Here the commit message mentions a co

Re: [libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-08-03 Thread madhu pavan
On 08/03/2015 06:23 PM, Ján Tomko wrote: On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote: PowerPC pseries based VMs do not support a floppy disk controller. Here the commit message mentions a controller, but the code only checks for the device, not for Should we forb

Re: [libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-08-03 Thread Ján Tomko
On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote: > PowerPC pseries based VMs do not support a floppy disk controller. Here the commit message mentions a controller, but the code only checks for the device, not for Should we forbid that one too? AFAIK we've auto-added it t

[libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-07-30 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_command.c |8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/