Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

2015-10-01 Thread Pavel Fedin
Hello! > > And also we could add some another boolean, which would allow to disable > > in-kernel GIC > emulation > >(kernel_irqchip=off). This works with any machine type, BTW, not only with > >ARM. Something > like >kvm='off'/>. > > > > I don't know what that is. Is that only GIC related?

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

2015-10-01 Thread Pavel Fedin
Hello! > Indentation's off here. Damn, sorry, overlooked... > Also before this patch we would allow def->gic_version == 2 for any > machine type. I don't have a problem with this since GIC doesn't make > sense anywhere else then on ARM machines, I'm OK with this. I used 0 for 'no version

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

2015-10-01 Thread Martin Kletzander
On Thu, Oct 01, 2015 at 09:53:00AM +0300, Pavel Fedin wrote: Hello! > Indentation's off here. Damn, sorry, overlooked... Also before this patch we would allow def->gic_version == 2 for any machine type. I don't have a problem with this since GIC doesn't make sense anywhere else then on ARM

[libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

2015-09-30 Thread Pavel Fedin
Support for GICv3 has been recently introduced in qemu using gic-version option for the 'virt' machine. The option can actually take values of '2', '3' and 'host', however, since in libvirt this is a numeric parameter, we limit it only to 2 and 3. Value of 2 is not added to the command line in

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

2015-09-30 Thread Martin Kletzander
On Wed, Sep 30, 2015 at 02:04:10PM +0300, Pavel Fedin wrote: Support for GICv3 has been recently introduced in qemu using gic-version option for the 'virt' machine. The option can actually take values of '2', '3' and 'host', however, since in libvirt this is a numeric parameter, we limit it only