Re: [libvirt] [PATCH v2 2/7] util: move all firewalld-specific stuff into its own files

2019-02-01 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 08:24:53PM -0500, Laine Stump wrote: > In preparation for adding several other firewalld-specific functions, > separate the code that's unique to firewalld from the more-generic > "firewall" file. > > Signed-off-by: Laine Stump > --- > > Change from V1: define

[libvirt] [PATCH v2 2/7] util: move all firewalld-specific stuff into its own files

2019-01-31 Thread Laine Stump
In preparation for adding several other firewalld-specific functions, separate the code that's unique to firewalld from the more-generic "firewall" file. Signed-off-by: Laine Stump --- Change from V1: define VIR_FIREWALL_FIREWALLD_SERVICE in virfirewalldpriv.h, since it should only be used by