Re: [libvirt] [PATCH v2 4/5] Remove incorrectly used TODO macro

2017-07-06 Thread Jim Fehlig
On 07/05/2017 05:58 AM, Daniel P. Berrange wrote: The TODO macro expands to an fprintf() call and is used in several places in the Xen driver. Anything that wishes to print such debug messages should use the logging macros. In this case though, all the places in the Xen driver should have been

[libvirt] [PATCH v2 4/5] Remove incorrectly used TODO macro

2017-07-05 Thread Daniel P. Berrange
The TODO macro expands to an fprintf() call and is used in several places in the Xen driver. Anything that wishes to print such debug messages should use the logging macros. In this case though, all the places in the Xen driver should have been raising a formal libvirt error instead. Add proper