[libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri-server will be always properly assigned and it doesn't have to be changed when used on some new place in the

Re: [libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Eric Blake
On 02/24/2012 11:09 AM, Martin Kletzander wrote: Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri-server will be always properly assigned and it doesn't

Re: [libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Daniel P. Berrange
On Fri, Feb 24, 2012 at 07:09:49PM +0100, Martin Kletzander wrote: +xmlURIPtr +virURIParse(const char *uri) +unsigned char * +virURIFormat(xmlURIPtr uri) The data types here are wrong compared to the header. Also the return value should not be unsigned - that is libxml2 bad practice we