Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-07-05 Thread Olaf Hering
On Wed, Jul 04, Daniel P. Berrangé wrote: > On Wed, Jul 04, 2018 at 01:48:56PM +0200, Olaf Hering wrote: > > Since bind() already succeeded (or will succeed) for one address, there is > > no reason to error out. Anyone who connects to an resolved ipv6 address will > > get an error, and moves on

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-07-04 Thread Daniel P . Berrangé
On Wed, Jul 04, 2018 at 01:48:56PM +0200, Olaf Hering wrote: > Am Wed, 4 Jul 2018 11:57:58 +0100 > schrieb Daniel P. Berrangé : > > > On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: > > > In this case the resolver returns not only the IPv4 addresses but also > > > IPv6. Binding the

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-07-04 Thread Olaf Hering
Am Wed, 4 Jul 2018 11:57:58 +0100 schrieb Daniel P. Berrangé : > On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: > > In this case the resolver returns not only the IPv4 addresses but also > > IPv6. Binding the IPv6 address will obviously fail. But this terminates > > the entire loop,

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-07-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: > Currently virNetSocketNewListenTCP bails out early under the following > conditions: > - the hostname resolves to at least one IPv4 and at least one IPv6 > address > - the local interfaces have that one IPv4 address assigned, but not

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-07-04 Thread Olaf Hering
Am Mon, 4 Jun 2018 12:29:37 +0200 schrieb Olaf Hering : > Currently virNetSocketNewListenTCP bails out early under the following > conditions: > - the hostname resolves to at least one IPv4 and at least one IPv6 > address > - the local interfaces have that one IPv4 address assigned, but not

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-06-04 Thread Olaf Hering
Am Mon, 4 Jun 2018 21:16:17 +0200 schrieb Ján Tomko : > On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: > >-goto error; > This skips all errors, not just EADDRNOTAVAIL. Saving the errno here... Why would any error matter here? Why was that one 'goto error;' ever

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-06-04 Thread Ján Tomko
On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: Currently virNetSocketNewListenTCP bails out early under the following conditions: - the hostname resolves to at least one IPv4 and at least one IPv6 address - the local interfaces have that one IPv4 address assigned, but not any of

[libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

2018-06-04 Thread Olaf Hering
Currently virNetSocketNewListenTCP bails out early under the following conditions: - the hostname resolves to at least one IPv4 and at least one IPv6 address - the local interfaces have that one IPv4 address assigned, but not any of the IPv6 addresses - the local interfaces have just IPv6