Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-23 Thread Martin Kletzander
On Thu, Jun 22, 2017 at 05:55:12PM -0300, Julio Faracco wrote: Twos question related to this topic: 1. Is virstringtest missing some important tests from virstring.c? I'm not seeing vir{StrToDouble|DoubleToStr}... 2. Should locale be considered during the test phase too? Yep, it would be nice

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-22 Thread Julio Faracco
Twos question related to this topic: 1. Is virstringtest missing some important tests from virstring.c? I'm not seeing vir{StrToDouble|DoubleToStr}... 2. Should locale be considered during the test phase too? 2017-06-22 8:23 GMT-03:00 Martin Kletzander : > On Thu, Jun 22,

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-22 Thread Martin Kletzander
On Thu, Jun 22, 2017 at 01:12:44PM +0200, Peter Krempa wrote: On Thu, Jun 22, 2017 at 11:30:06 +0200, Martin Kletzander wrote: On Wed, Jun 21, 2017 at 02:08:27PM -0300, Julio Faracco wrote: > The commits add locale support for virStrToDouble() due to differences between > the mantissa separator

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-22 Thread Peter Krempa
On Thu, Jun 22, 2017 at 11:30:06 +0200, Martin Kletzander wrote: > On Wed, Jun 21, 2017 at 02:08:27PM -0300, Julio Faracco wrote: > > The commits add locale support for virStrToDouble() due to differences > > between > > the mantissa separator in different languages. For example, kernel always >

Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-22 Thread Martin Kletzander
On Wed, Jun 21, 2017 at 02:08:27PM -0300, Julio Faracco wrote: The commits add locale support for virStrToDouble() due to differences between the mantissa separator in different languages. For example, kernel always uses dot to separate mantissa. An user who is using pt_BR locale (for example)

[libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().

2017-06-21 Thread Julio Faracco
The commits add locale support for virStrToDouble() due to differences between the mantissa separator in different languages. For example, kernel always uses dot to separate mantissa. An user who is using pt_BR locale (for example) uses comma as a separator. So, this user will have problems to