Re: [libvirt] [PATCH v3 03/12] conf: Introduce a new PCI address extension flag

2018-08-20 Thread Yi Min Zhao
在 2018/8/16 下午10:44, Andrea Bolognani 写道: On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: [...] +qemuDomainDeviceSupportZPCI(virDomainDeviceDefPtr device) +{ +switch ((virDomainDeviceType) device->type) { +case VIR_DOMAIN_DEVICE_CHR: +return false; + +case VIR_DOMAIN_

Re: [libvirt] [PATCH v3 03/12] conf: Introduce a new PCI address extension flag

2018-08-17 Thread Andrea Bolognani
On Fri, 2018-08-17 at 06:41 +0200, Bjoern Walk wrote: > Andrea Bolognani [2018-08-16, 04:44PM +0200]: > > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: > > > +case VIR_DOMAIN_DEVICE_NONE: > > > +case VIR_DOMAIN_DEVICE_LAST: > > > > Missing 'default' case. > > I thought we explici

Re: [libvirt] [PATCH v3 03/12] conf: Introduce a new PCI address extension flag

2018-08-16 Thread Bjoern Walk
Andrea Bolognani [2018-08-16, 04:44PM +0200]: > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: > [...] > > +qemuDomainDeviceSupportZPCI(virDomainDeviceDefPtr device) > > +{ > > +switch ((virDomainDeviceType) device->type) { > > +case VIR_DOMAIN_DEVICE_CHR: > > +return false;

Re: [libvirt] [PATCH v3 03/12] conf: Introduce a new PCI address extension flag

2018-08-16 Thread Andrea Bolognani
On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: [...] > +qemuDomainDeviceSupportZPCI(virDomainDeviceDefPtr device) > +{ > +switch ((virDomainDeviceType) device->type) { > +case VIR_DOMAIN_DEVICE_CHR: > +return false; > + > +case VIR_DOMAIN_DEVICE_CONTROLLER: > +case VI

[libvirt] [PATCH v3 03/12] conf: Introduce a new PCI address extension flag

2018-08-07 Thread Yi Min Zhao
This patch introduces a new attribute PCI address extension flag to deal with the extension PCI attributes such as 'uid' and 'fid' on the S390 platform. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Ján Tomko --- src/conf/device_conf.h | 1 + src/conf/domain_a