Re: [libvirt] [PATCH v3 04/21] LXC from native: migrate fstab and lxc.mount.entry

2014-02-13 Thread John Ferlan
New Coverity complaint regarding this change ... ...snip... virDomainDefPtr lxcParseConfigString(const char *config) { @@ -115,6 +343,7 @@ lxcParseConfigString(const char *config) _(failed to generate uuid)); goto error; } + vmdef-id = -1;

Re: [libvirt] [PATCH v3 04/21] LXC from native: migrate fstab and lxc.mount.entry

2014-02-13 Thread Cedric Bosdonnat
On Thu, 2014-02-13 at 06:34 -0500, John Ferlan wrote: New Coverity complaint regarding this change ... ...snip... virDomainDefPtr lxcParseConfigString(const char *config) { @@ -115,6 +343,7 @@ lxcParseConfigString(const char *config) _(failed to generate

Re: [libvirt] [PATCH v3 04/21] LXC from native: migrate fstab and lxc.mount.entry

2014-02-12 Thread Daniel P. Berrange
On Wed, Feb 05, 2014 at 03:10:02PM +0100, Cédric Bosdonnat wrote: Tmpfs relative size and default 50% size values aren't supported as we have no idea of the available memory at the conversion time. --- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_container.h

[libvirt] [PATCH v3 04/21] LXC from native: migrate fstab and lxc.mount.entry

2014-02-05 Thread Cédric Bosdonnat
Tmpfs relative size and default 50% size values aren't supported as we have no idea of the available memory at the conversion time. --- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_container.h | 2 + src/lxc/lxc_native.c