Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-12 Thread Erik Skultety
On Wed, Jul 11, 2018 at 08:36:59PM +0530, Sukrit Bhatnagar wrote: > The problem is not that it is initialized to a non-NULL value. > If we were to detect multiple declarations in a line. we would > search for a comma (separator), right? In the case I mentioned, > the comma inside the function has t

Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-11 Thread Sukrit Bhatnagar
The problem is not that it is initialized to a non-NULL value. If we were to detect multiple declarations in a line. we would search for a comma (separator), right? In the case I mentioned, the comma inside the function has to be avoided by the rule. On Wed, 11 Jul 2018 at 15:57, Erik Skultety wro

Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-11 Thread Erik Skultety
On Wed, Jul 11, 2018 at 10:35:25AM +0200, Pavel Hrdina wrote: > On Wed, Jul 11, 2018 at 12:42:43AM +0530, Sukrit Bhatnagar wrote: > > On Tue, 10 Jul 2018 at 16:24, Erik Skultety wrote: > > > > > > On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote: > > > > Add rule to ensure that eac

Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-11 Thread Pavel Hrdina
On Wed, Jul 11, 2018 at 12:42:43AM +0530, Sukrit Bhatnagar wrote: > On Tue, 10 Jul 2018 at 16:24, Erik Skultety wrote: > > > > On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote: > > > Add rule to ensure that each variable declaration made using > > > a cleanup macro is in its own se

Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-10 Thread Sukrit Bhatnagar
On Tue, 10 Jul 2018 at 16:24, Erik Skultety wrote: > > On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote: > > Add rule to ensure that each variable declaration made using > > a cleanup macro is in its own separate line. > > > > Sometimes a variable might be initialized from a value

Re: [libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-10 Thread Erik Skultety
On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote: > Add rule to ensure that each variable declaration made using > a cleanup macro is in its own separate line. > > Sometimes a variable might be initialized from a value returned > by a macro or a function, which may take on more than

[libvirt] [PATCH v3 04/35] cfg.mk: single variable declaration per line when using cleanup macro

2018-07-01 Thread Sukrit Bhatnagar
Add rule to ensure that each variable declaration made using a cleanup macro is in its own separate line. Sometimes a variable might be initialized from a value returned by a macro or a function, which may take on more than one parameter, thereby introducing a comma, which might be mistaken for mu