Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-12 Thread Andrea Bolognani
On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: >  > Just a question, I know it's to late to change those patches, it's pushed now, > but why don't we unify the help string for all the commands?  It does the same > thing for all commands, there is no reason to have different help string for

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-12 Thread Pavel Hrdina
On Mon, Jan 11, 2016 at 05:26:55PM +0100, Andrea Bolognani wrote: > On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: > > > > > The config option for the 'schedinfo' and 'change-media' > > > commands, while it has a slightly different help text, also > > > serves AFAICT the same purpose and as

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-12 Thread John Ferlan
On 01/12/2016 06:40 AM, Pavel Hrdina wrote: > On Tue, Jan 12, 2016 at 10:53:03AM +0100, Andrea Bolognani wrote: >> On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: >>> >>> Just a question, I know it's to late to change those patches, it's pushed >>> now, >>> but why don't we unify the

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-12 Thread Pavel Hrdina
On Tue, Jan 12, 2016 at 10:53:03AM +0100, Andrea Bolognani wrote: > On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote: > >  > > Just a question, I know it's to late to change those patches, it's pushed > > now, > > but why don't we unify the help string for all the commands?  It does the > >

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread John Ferlan
On 01/11/2016 11:26 AM, Andrea Bolognani wrote: > On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: >> >>> The config option for the 'schedinfo' and 'change-media' >>> commands, while it has a slightly different help text, also >>> serves AFAICT the same purpose and as such should IMHO use

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread Andrea Bolognani
On Mon, 2016-01-11 at 13:21 +0100, Andrea Bolognani wrote: >  > The config option for the 'schedinfo' and 'change-media' > commands, while it has a slightly different help text, also > serves AFAICT the same purpose and as such should IMHO use the > macro you just defined as well. Ignore the bit

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread Andrea Bolognani
On Mon, 2016-01-11 at 13:21 +0100, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > > Rather than continually cut-n-paste the strings into each command, > > create a common macro to be used generically.  Note that not all > > '{.name = "config",' entries are

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread Andrea Bolognani
On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "config",' entries are replaced, just those that have the > common .help string of "affect next

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread Andrea Bolognani
On Mon, 2016-01-11 at 10:55 -0500, John Ferlan wrote: > > > The config option for the 'schedinfo' and 'change-media' > > commands, while it has a slightly different help text, also > > serves AFAICT the same purpose and as such should IMHO use the > > macro you just defined as well. >  > BTW: I

Re: [libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-11 Thread John Ferlan
On 01/11/2016 07:21 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create a common macro to be used generically. Note that not all >> '{.name = "config",' entries are replaced, just

[libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

2016-01-09 Thread John Ferlan
Rather than continually cut-n-paste the strings into each command, create a common macro to be used generically. Note that not all '{.name = "config",' entries are replaced, just those that have the common .help string of "affect next boot". Non replaced instances are unique to the command.