Re: [libvirt] [PATCH v3 06/10] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-10-16 Thread Daniel Henrique Barboza
On 10/16/19 11:28 AM, Ján Tomko wrote: On Wed, Oct 16, 2019 at 11:14:05AM -0300, Daniel Henrique Barboza wrote: On 10/16/19 10:49 AM, Ján Tomko wrote: On Tue, Oct 15, 2019 at 05:08:48PM -0300, Daniel Henrique Barboza wrote: Using VIR_AUTOFREE() in all strings of qemu_driver.c make the

Re: [libvirt] [PATCH v3 06/10] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-10-16 Thread Ján Tomko
On Wed, Oct 16, 2019 at 11:14:05AM -0300, Daniel Henrique Barboza wrote: On 10/16/19 10:49 AM, Ján Tomko wrote: On Tue, Oct 15, 2019 at 05:08:48PM -0300, Daniel Henrique Barboza wrote: Using VIR_AUTOFREE() in all strings of qemu_driver.c make the code a bit tidier and smaller, sparing

Re: [libvirt] [PATCH v3 06/10] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-10-16 Thread Daniel Henrique Barboza
On 10/16/19 10:49 AM, Ján Tomko wrote: On Tue, Oct 15, 2019 at 05:08:48PM -0300, Daniel Henrique Barboza wrote: Using VIR_AUTOFREE() in all strings of qemu_driver.c make the code a bit tidier and smaller, sparing VIR_FREE() calls and sometimes a whole 'cleanup' label. These patches would

Re: [libvirt] [PATCH v3 06/10] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-10-16 Thread Ján Tomko
On Tue, Oct 15, 2019 at 05:08:48PM -0300, Daniel Henrique Barboza wrote: Using VIR_AUTOFREE() in all strings of qemu_driver.c make the code a bit tidier and smaller, sparing VIR_FREE() calls and sometimes a whole 'cleanup' label. These patches would look much better split by: * individual

[libvirt] [PATCH v3 06/10] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-10-15 Thread Daniel Henrique Barboza
Using VIR_AUTOFREE() in all strings of qemu_driver.c make the code a bit tidier and smaller, sparing VIR_FREE() calls and sometimes a whole 'cleanup' label. This is a huge change due to the amount of char * declared in this file, thus let's split it in 3. This is the first part. Signed-off-by: