On Fri, Apr 12, 2013 at 03:24:04PM -0600, Eric Blake wrote:
> On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
>
> > +++ b/tests/Makefile.am
> > @@ -97,7 +97,9 @@ test_programs = virshtest sockettest \
> > utiltest shunloadtest \
> > virtimetest viruritest virkeyfiletest \
> > virauth
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Some aspects of the cgroups setup / detection code are quite subtle
> and easy to break. It would greatly benefit from unit testing, but
> this is difficult because the test suite won't have privileges to
> play ar
On Wed, Apr 10, 2013 at 09:04:33PM -0600, Eric Blake wrote:
> On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Some aspects of the cgroups setup / detection code are quite subtle
> > and easy to break. It would greatly benefit from unit testing, but
> > thi
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Some aspects of the cgroups setup / detection code are quite subtle
> and easy to break. It would greatly benefit from unit testing, but
> this is difficult because the test suite won't have privileges to
> play ar
From: "Daniel P. Berrange"
Some aspects of the cgroups setup / detection code are quite subtle
and easy to break. It would greatly benefit from unit testing, but
this is difficult because the test suite won't have privileges to
play around with cgroups. The solution is to use monkey patching
via
