Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 11:24 +, Daniel P. Berrangé wrote: > On Fri, Nov 08, 2019 at 12:15:53PM +0100, Andrea Bolognani wrote: > > On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > > > Moving this HAVE_GNU_GETTEXT_TOOLS conditional means that on OS that > > > lack the GNU gettext

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:15:53PM +0100, Andrea Bolognani wrote: > On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > > On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > > > -endif HAVE_GNU_GETTEXT_TOOLS > > > - > > > if ENABLE_NLS > > > > > > # Cannot use

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Andrea Bolognani
On Fri, 2019-11-08 at 10:04 +, Daniel P. Berrangé wrote: > On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > > -endif HAVE_GNU_GETTEXT_TOOLS > > - > > if ENABLE_NLS > > > > # Cannot use 'localedir' since this conflicts with autoconf. > > @@ -99,7 +104,7 @@ install-data-hook:

Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-11-08 Thread Daniel P . Berrangé
On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > Historically we did not support VPATH builds and everything was > generated into source directory. The introduction of VPATH builds > did not changed the way how our translation files are handled. > > This patch changes the rules to

[libvirt] [PATCH v3 06/20] po: generate files into build directory

2019-10-24 Thread Pavel Hrdina
Historically we did not support VPATH builds and everything was generated into source directory. The introduction of VPATH builds did not changed the way how our translation files are handled. This patch changes the rules to generate everything into build directory and stops distributing