Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-08 Thread Anirban Chakraborty
On 12/8/14, 2:10 AM, "Daniel P. Berrange" wrote: >On Fri, Dec 05, 2014 at 11:37:05PM +, Anirban Chakraborty wrote: >> >> >> On 12/5/14, 10:43 AM, "Laine Stump" wrote: >> >> >On 12/05/2014 06:12 AM, Michal Privoznik wrote: >> >> @@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virComm

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-08 Thread Vasiliy Tolstov
2014-12-08 23:51 GMT+03:00 Anirban Chakraborty : > > Yes, that will work. So as i see two different point of view... I want to get this patch in next libvirt release What i need to do? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru -- libvir-list mailing list libvir

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-08 Thread Anirban Chakraborty
On 12/6/14, 2:51 AM, "Vasiliy Tolstov" wrote: >2014-12-06 2:37 GMT+03:00 Anirban Chakraborty : >> In Open Contrail (www.opencontrail.org), we use this feature where tap >> interface is created first, so that we know the name of the tap device a >> priori, before creating the vm. So, this patch

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-08 Thread Daniel P. Berrange
On Fri, Dec 05, 2014 at 11:37:05PM +, Anirban Chakraborty wrote: > > > On 12/5/14, 10:43 AM, "Laine Stump" wrote: > > >On 12/05/2014 06:12 AM, Michal Privoznik wrote: > >> @@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, > >> } > >> > >> if (actualType == V

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-06 Thread Vasiliy Tolstov
2014-12-06 2:37 GMT+03:00 Anirban Chakraborty : > In Open Contrail (www.opencontrail.org), we use this feature where tap > interface is created first, so that we know the name of the tap device a > priori, before creating the vm. So, this patch will break existing code. May be we can add some fla

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Anirban Chakraborty
On 12/5/14, 10:43 AM, "Laine Stump" wrote: >On 12/05/2014 06:12 AM, Michal Privoznik wrote: >> @@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, >> } >> >> if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || >> -actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { >

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Laine Stump
On 12/05/2014 06:12 AM, Michal Privoznik wrote: > @@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, > } > > if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK || > -actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { > +actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Vasiliy Tolstov
2014-12-05 20:22 GMT+03:00 Daniel P. Berrange : > I'm still somewhat inclined to leave the config as "tainted" though, > simply because of the fact that the scripts are an opaque black box > that we don't have visiblity into. So they definitely have the > potential to screw up host or guest config

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Daniel P. Berrange
On Fri, Dec 05, 2014 at 09:57:36AM -0700, Eric Blake wrote: > On 12/05/2014 04:18 AM, Daniel P. Berrange wrote: > > On Fri, Dec 05, 2014 at 12:12:46PM +0100, Michal Privoznik wrote: > >> From: Vasiliy Tolstov > >> > >> If a user doesn't specify script in network type ethernet, assume > >> that he/

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Eric Blake
On 12/05/2014 04:18 AM, Daniel P. Berrange wrote: > On Fri, Dec 05, 2014 at 12:12:46PM +0100, Michal Privoznik wrote: >> From: Vasiliy Tolstov >> >> If a user doesn't specify script in network type ethernet, assume >> that he/she needs a simple tap device created by libvirt. This >> commit does no

Re: [libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Daniel P. Berrange
On Fri, Dec 05, 2014 at 12:12:46PM +0100, Michal Privoznik wrote: > From: Vasiliy Tolstov > > If a user doesn't specify script in network type ethernet, assume > that he/she needs a simple tap device created by libvirt. This > commit does not need to run external script to create tap device > or

[libvirt] [PATCH v3 2/2] qemu: Automaticly create tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2014-12-05 Thread Michal Privoznik
From: Vasiliy Tolstov If a user doesn't specify script in network type ethernet, assume that he/she needs a simple tap device created by libvirt. This commit does not need to run external script to create tap device or add root to qemu process. Moreover, some functions need to be mocked now for q