Re: [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Eric Blake
On 03/04/2014 11:40 PM, Amos Kong wrote: but the docs imply that I should now see: {parameters: [], option: smbios, argument: true} I really got : {parameters: [], option: smbios, argument: true} (I was testing with latest qemu upstream + my patches, attached the output file) Hmm,

Re: [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Eric Blake
On 03/05/2014 08:58 AM, Eric Blake wrote: On 03/04/2014 11:40 PM, Amos Kong wrote: but the docs imply that I should now see: {parameters: [], option: smbios, argument: true} I really got : {parameters: [], option: smbios, argument: true} (I was testing with latest qemu upstream + my

Re: [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-05 Thread Amos Kong
On Wed, Mar 05, 2014 at 11:50:22AM -0700, Eric Blake wrote: On 03/05/2014 08:58 AM, Eric Blake wrote: On 03/04/2014 11:40 PM, Amos Kong wrote: but the docs imply that I should now see: {parameters: [], option: smbios, argument: true} I really got : {parameters: [], option: smbios,

Re: [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-04 Thread Eric Blake
On 03/03/2014 10:51 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be

Re: [libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-04 Thread Amos Kong
On Tue, Mar 04, 2014 at 03:03:08PM -0700, Eric Blake wrote: Hi Eric, On 03/03/2014 10:51 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current

[libvirt] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be lost. We have some macros in qemu-options.hx