Re: [libvirt] [PATCH v3 27/30] qemu: Don't leak storage perms on failure in qemuDomainAttachDiskGeneric

2019-12-10 Thread Cole Robinson
On 12/2/19 9:26 AM, Michal Privoznik wrote: > At the very beginning of the attach function the > qemuDomainStorageSourceChainAccessAllow() is called which > modifies CGroups, locks and seclabels for new disk and its > backing chain. This must be followed by a counterpart which > reverts back all

[libvirt] [PATCH v3 27/30] qemu: Don't leak storage perms on failure in qemuDomainAttachDiskGeneric

2019-12-02 Thread Michal Privoznik
At the very beginning of the attach function the qemuDomainStorageSourceChainAccessAllow() is called which modifies CGroups, locks and seclabels for new disk and its backing chain. This must be followed by a counterpart which reverts back all the changes if something goes wrong. This boils down to