Re: [libvirt] [PATCH v3 3/4] scsi: Adjust return value for virStorageBackendSCSINewLun

2015-04-17 Thread Ján Tomko
On Thu, Apr 16, 2015 at 07:42:55PM -0400, John Ferlan wrote: On 04/16/2015 09:14 AM, Ján Tomko wrote: On Tue, Apr 07, 2015 at 04:21:02PM -0400, John Ferlan wrote: Use virStorageBackendPoolUseDevPath API to determine whether creation of stable target path is possible for the volume. If

Re: [libvirt] [PATCH v3 3/4] scsi: Adjust return value for virStorageBackendSCSINewLun

2015-04-17 Thread John Ferlan
work - so we'll short circuit here. This also rejects the non-stable path '/dev' that was accepted before. Not quite sure I see the issue - can you be more specific? Am I missing something obvious? Previously if pool-def-target.path is /dev (or NULL or /dev/ or didn't start with /dev),

Re: [libvirt] [PATCH v3 3/4] scsi: Adjust return value for virStorageBackendSCSINewLun

2015-04-16 Thread Ján Tomko
On Tue, Apr 07, 2015 at 04:21:02PM -0400, John Ferlan wrote: Use virStorageBackendPoolUseDevPath API to determine whether creation of stable target path is possible for the volume. If not, then return failure. This will differentiate a failed virStorageBackendStablePath which won't need to

Re: [libvirt] [PATCH v3 3/4] scsi: Adjust return value for virStorageBackendSCSINewLun

2015-04-16 Thread John Ferlan
On 04/16/2015 09:14 AM, Ján Tomko wrote: On Tue, Apr 07, 2015 at 04:21:02PM -0400, John Ferlan wrote: Use virStorageBackendPoolUseDevPath API to determine whether creation of stable target path is possible for the volume. If not, then return failure. This will differentiate a failed

[libvirt] [PATCH v3 3/4] scsi: Adjust return value for virStorageBackendSCSINewLun

2015-04-07 Thread John Ferlan
Use virStorageBackendPoolUseDevPath API to determine whether creation of stable target path is possible for the volume. If not, then return failure. This will differentiate a failed virStorageBackendStablePath which won't need to be fatal. Thus, we'll add a -2 return value to differentiate that