Re: [libvirt] [PATCH v3 5/5] virt-aa-helper: test: check for expected profile content

2018-03-21 Thread Christian Ehrhardt
On Wed, Mar 21, 2018 at 7:59 PM, Jamie Strandboge wrote: > On Wed, 2018-03-21 at 15:53 +0100, Christian Ehrhardt wrote: > > So far the virt-aa-helper tests only checked the return code and > > thereby > > catched aborts like issues failing to parse the XML. But there is one

Re: [libvirt] [PATCH v3 5/5] virt-aa-helper: test: check for expected profile content

2018-03-21 Thread Jamie Strandboge
On Wed, 2018-03-21 at 15:53 +0100, Christian Ehrhardt wrote: > So far the virt-aa-helper tests only checked the return code and > thereby > catched aborts like issues failing to parse the XML. But there is one > category of virt-aa-helper issues so far untested - not generating > the > expected

[libvirt] [PATCH v3 5/5] virt-aa-helper: test: check for expected profile content

2018-03-21 Thread Christian Ehrhardt
So far the virt-aa-helper tests only checked the return code and thereby catched aborts like issues failing to parse the XML. But there is one category of virt-aa-helper issues so far untested - not generating the expected rule. This adds a basic grep based checks after each test to match against