Re: [libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-18 Thread Laine Stump
On 02/13/2014 03:17 PM, Michal Privoznik wrote: On 13.02.2014 12:10, Laine Stump wrote: On 02/12/2014 08:20 PM, Laine Stump wrote: It all looks fine (aside from the few small grammar corrections in the docs. I just want one last confirmation that we don't want both plug and plugged events,

Re: [libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-18 Thread Michal Privoznik
On 18.02.2014 12:20, Laine Stump wrote: On 02/13/2014 03:17 PM, Michal Privoznik wrote: On 13.02.2014 12:10, Laine Stump wrote: On 02/12/2014 08:20 PM, Laine Stump wrote: It all looks fine (aside from the few small grammar corrections in the docs. I just want one last confirmation that we

Re: [libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-13 Thread Laine Stump
On 02/12/2014 08:20 PM, Laine Stump wrote: It all looks fine (aside from the few small grammar corrections in the docs. I just want one last confirmation that we don't want both plug and plugged events, and in that case ACK. A few marginally related things came to my mind since I sent that

Re: [libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-13 Thread Michal Privoznik
On 13.02.2014 12:10, Laine Stump wrote: On 02/12/2014 08:20 PM, Laine Stump wrote: It all looks fine (aside from the few small grammar corrections in the docs. I just want one last confirmation that we don't want both plug and plugged events, and in that case ACK. A few marginally related

[libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-12 Thread Michal Privoznik
There might be some use cases, where user wants to prepare the host or its environment prior to starting a network and do some cleanup after the network has been shut down. Consider all the functionality that libvirt doesn't currently have as an example what a hook script can possibly do.

Re: [libvirt] [PATCH v4 2/3] network: Introduce network hooks

2014-02-12 Thread Laine Stump
On 02/12/2014 07:07 PM, Michal Privoznik wrote: There might be some use cases, where user wants to prepare the host or its environment prior to starting a network and do some cleanup after the network has been shut down. Consider all the functionality that libvirt doesn't currently have as an