Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

2018-04-26 Thread Michal Privoznik
On 04/26/2018 09:34 PM, Peter Krempa wrote: > On Thu, Apr 26, 2018 at 18:00:15 +0200, Michal Privoznik wrote: >> On 04/26/2018 02:56 PM, Ján Tomko wrote: >>> On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: > > [...] > >> So what was the showstopper for this patch? I wanted to

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

2018-04-26 Thread Peter Krempa
: Thu, 26 Apr 2018 14:56:58 +0200 Subject: Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard tag v4.3.0-rc1 TaggerDate: Thu Apr 26 14:56:34 2018 +0200 which was announced on the mailing list 15 minutes later. Date: Thu, 26 Apr 2018 15:12:05 +0200 Subject: [libvirt] Entering

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

2018-04-26 Thread Michal Privoznik
On 04/26/2018 02:56 PM, Ján Tomko wrote: > On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1480668 >> >> QEMU has this new feature memory-backend-file.discard-data=yes >> which is a nifty optimization. Basically, when qemu is

Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

2018-04-26 Thread Ján Tomko
On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close()

[libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

2018-04-20 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close() on the file that is backing the memory. However, this does not mean