Re: [libvirt] [PATCH v4 5/7] qemu: Add secinfo for hotplug virtio disk

2016-07-15 Thread John Ferlan
[...] >> qemuDomainObjEnterMonitor(driver, vm); >> >> +if (secobjProps && qemuMonitorAddObject(priv->mon, "secret", >> +secinfo->s.aes.alias, >> +secobjProps) < 0) >> +goto exit_monitor; >> +

Re: [libvirt] [PATCH v4 5/7] qemu: Add secinfo for hotplug virtio disk

2016-07-14 Thread Ján Tomko
On Mon, Jul 11, 2016 at 02:07:56PM -0400, John Ferlan wrote: Commit id 'a1344f70a' added AES secret processing for RBD when starting up a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare an AES secret could be added to the disk about to be hotplugged. If an AES secret was

[libvirt] [PATCH v4 5/7] qemu: Add secinfo for hotplug virtio disk

2016-07-11 Thread John Ferlan
Commit id 'a1344f70a' added AES secret processing for RBD when starting up a guest. As such, when the hotplug code calls qemuDomainSecretDiskPrepare an AES secret could be added to the disk about to be hotplugged. If an AES secret was added, then the hotplug code would need to generate the secret