Re: [libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-16 Thread Yi Min Zhao
在 2018/9/13 下午7:47, Andrea Bolognani 写道: Just remove the full stop, like virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("This QEMU binary doesn't support zPCI")); AhGot it. -- Yi Min -- libvir-list mailing list libvir-list@redhat.com https://ww

Re: [libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-13 Thread Andrea Bolognani
On Thu, 2018-09-13 at 18:08 +0800, Yi Min Zhao wrote: > > [...] > > > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > > > + "%s", > > > + _("This QEMU binary doesn't support zPCI.")); > > > > No full stop at the end of the error message, please. >

Re: [libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-13 Thread Yi Min Zhao
在 2018/9/11 下午8:44, Andrea Bolognani 写道: On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: We should ensure that the Qemu should support zPCI when zPCI address is s/Qemu/QEMU/ Sure. [...] +static int +qemuDomainZPCIAddressDefValidate(virDomainDeviceDef *dev, +

Re: [libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-11 Thread Andrea Bolognani
On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote: > We should ensure that the Qemu should support zPCI when zPCI address is s/Qemu/QEMU/ [...] > +static int > +qemuDomainZPCIAddressDefValidate(virDomainDeviceDef *dev, > + virQEMUCapsPtr qemuCaps) The secon

[libvirt] [PATCH v5 08/13] qemu: Add zPCI address definition check

2018-09-04 Thread Yi Min Zhao
We should ensure that the Qemu should support zPCI when zPCI address is defined in XML. Otherwise the error should be reported. So this patch introduces the validation of zPCI address definition for qemuDomainDeviceDefValidate(). Signed-off-by: Yi Min Zhao --- src/qemu/qemu_domain.c | 26 +++