Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-19 Thread Yi Min Zhao
在 2018/10/19 下午3:54, Andrea Bolognani 写道: On Fri, 2018-10-19 at 11:29 +0800, Yi Min Zhao wrote: 在 2018/10/18 下午11:44, Andrea Bolognani 写道: There's still the question of whether Dan is now okay with the XML structure as currently implemented; assuming that's the case, it would be great if

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-19 Thread Andrea Bolognani
On Fri, 2018-10-19 at 11:29 +0800, Yi Min Zhao wrote: > 在 2018/10/18 下午11:44, Andrea Bolognani 写道: > > There's still the question of whether Dan is now okay with the XML > > structure as currently implemented; assuming that's the case, it > > would be great if Laine could also take a quick look at

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-18 Thread Yi Min Zhao
在 2018/10/18 下午11:44, Andrea Bolognani 写道: On Thu, 2018-10-18 at 15:13 +0800, Yi Min Zhao wrote: 在 2018/10/17 下午10:30, Andrea Bolognani 写道: On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: I think this would make things complex. If either PCI address or zPCI address exists, we have to

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-18 Thread Christian Borntraeger
On 10/18/2018 05:44 PM, Andrea Bolognani wrote: > On Thu, 2018-10-18 at 15:13 +0800, Yi Min Zhao wrote: >> 在 2018/10/17 下午10:30, Andrea Bolognani 写道: >>> On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: I think this would make things complex. If either PCI address or zPCI address

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-18 Thread Andrea Bolognani
On Thu, 2018-10-18 at 15:13 +0800, Yi Min Zhao wrote: > 在 2018/10/17 下午10:30, Andrea Bolognani 写道: > > On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: > > > I think this would make things complex. If either PCI address or > > > zPCI address exists, we have to do more checks for calling > > >

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-18 Thread Yi Min Zhao
在 2018/10/17 下午10:30, Andrea Bolognani 写道: On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: 在 2018/10/11 下午10:50, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: # conf/device_conf.h +virDeviceInfoPCIAddressExtensionIsPresent;

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-17 Thread Andrea Bolognani
On Tue, 2018-10-16 at 11:28 +0800, Yi Min Zhao wrote: > 在 2018/10/11 下午10:50, Andrea Bolognani 写道: > > On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: > > > # conf/device_conf.h > > > +virDeviceInfoPCIAddressExtensionIsPresent; > > > +virDeviceInfoPCIAddressExtensionIsWanted; > > >

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-15 Thread Yi Min Zhao
在 2018/10/11 下午10:50, Andrea Bolognani 写道: On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: # conf/device_conf.h +virDeviceInfoPCIAddressExtensionIsPresent; +virDeviceInfoPCIAddressExtensionIsWanted; virDeviceInfoPCIAddressIsPresent; virDeviceInfoPCIAddressIsWanted;

Re: [libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-10-11 Thread Andrea Bolognani
On Fri, 2018-09-28 at 16:46 +0800, Yi Min Zhao wrote: > # conf/device_conf.h > +virDeviceInfoPCIAddressExtensionIsPresent; > +virDeviceInfoPCIAddressExtensionIsWanted; > virDeviceInfoPCIAddressIsPresent; > virDeviceInfoPCIAddressIsWanted; > virDomainDeviceAddressIsValid; > @@ -119,6 +121,9 @@

[libvirt] [PATCH v6 09/13] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-09-28 Thread Yi Min Zhao
This patch adds new functions for reservation, assignment and release to handle the uid/fid. If the uid/fid is defined in the domain XML, they will be reserved directly in collecting phase. If zPCI address is empty, we will find out an available value for it from zPCI address hashtable, and