Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-25 Thread Michal Privoznik
On 21.09.2014 16:58, Laszlo Ersek wrote: Hi Cole and Michal, I'm attaching three patches: snip/ (2) Unfortunately, even libvirtd needs to be modified, in addition. My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I verified that with gdb), but libvirtd doesn't act upon

Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-25 Thread Laszlo Ersek
On 09/25/14 14:59, Michal Privoznik wrote: On 21.09.2014 16:58, Laszlo Ersek wrote: Hi Cole and Michal, I'm attaching three patches: snip/ (2) Unfortunately, even libvirtd needs to be modified, in addition. My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I verified

Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-25 Thread Cole Robinson
On 09/25/2014 10:08 AM, Laszlo Ersek wrote: On 09/25/14 14:59, Michal Privoznik wrote: (3) I just realized that a domain's name can change during its lifetime. Well, the only moment that we support that is migration. Otherwise the name can't be changed (it's not only varstore path that's

Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-22 Thread Cole Robinson
On 09/21/2014 10:58 AM, Laszlo Ersek wrote: Hi Cole and Michal, I'm attaching three patches: On 09/20/14 02:37, Cole Robinson wrote: On 09/17/2014 06:55 PM, Cole Robinson wrote: We expose a simple combobox with two entries: BIOS, and UEFI. The UEFI option is only selectable if 1) libvirt

Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-22 Thread Laszlo Ersek
On 09/22/14 18:37, Cole Robinson wrote: On 09/21/2014 10:58 AM, Laszlo Ersek wrote: (2) Unfortunately, even libvirtd needs to be modified, in addition. My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I verified that with gdb), but libvirtd doesn't act upon it correctly.

Re: [libvirt] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

2014-09-21 Thread Laszlo Ersek
Hi Cole and Michal, I'm attaching three patches: On 09/20/14 02:37, Cole Robinson wrote: On 09/17/2014 06:55 PM, Cole Robinson wrote: We expose a simple combobox with two entries: BIOS, and UEFI. The UEFI option is only selectable if 1) libvirt supports the necessary domcapabilities bits, 2)