Re: [libvirt] [PATCHv2] daemon: clean up daemonization

2011-12-28 Thread Eric Blake
On 12/27/2011 03:51 AM, Daniel Veillard wrote: On Fri, Dec 23, 2011 at 02:13:53PM -0700, Eric Blake wrote: Valgrind detected a pipe fd leak before the parent exits on success, introduced in commit 4296cea; by itself, the leak is not bad, since we immediately called _exit(), but we might as

Re: [libvirt] [PATCHv2] daemon: clean up daemonization

2011-12-27 Thread Daniel Veillard
On Fri, Dec 23, 2011 at 02:13:53PM -0700, Eric Blake wrote: Valgrind detected a pipe fd leak before the parent exits on success, introduced in commit 4296cea; by itself, the leak is not bad, since we immediately called _exit(), but we might as well be clean to make valgrind analysis easier.

Re: [libvirt] [PATCHv2] daemon: clean up daemonization

2011-12-25 Thread Alex Jia
Eric, thanks a lot, I think you're enjoying holiday, but you're always busy :-), Merry Christmas! Merry Christmas to everyone! Alex - Original Message - From: Eric Blake ebl...@redhat.com To: libvir-list@redhat.com Cc: Alex Jia a...@redhat.com Sent: Saturday, December 24, 2011 5:13:53

[libvirt] [PATCHv2] daemon: clean up daemonization

2011-12-23 Thread Eric Blake
Valgrind detected a pipe fd leak before the parent exits on success, introduced in commit 4296cea; by itself, the leak is not bad, since we immediately called _exit(), but we might as well be clean to make valgrind analysis easier. Meanwhile, if the daemon grandchild detects an error, the parent