Re: [libvirt] [PATCHv2 3/5] S390: QEMU driver support for CCW addresses

2013-02-11 Thread Daniel P. Berrange
On Fri, Feb 08, 2013 at 06:32:22PM +0100, Viktor Mihajlovski wrote: This commit adds the QEMU driver support for CCW addresses. The current QEMU only allows virtio devices to be attached to the CCW bus. We named the new capability indicating that support QEMU_CAPS_VIRTIO_CCW accordingly.

Re: [libvirt] [PATCHv2 3/5] S390: QEMU driver support for CCW addresses

2013-02-11 Thread Viktor Mihajlovski
On 02/11/2013 04:40 PM, Daniel P. Berrange wrote: I'm not a fan of this approach. The capabilities data is reflecting what the QEMU binary is capable of supporting, *regardless* of what guest config is chosen. not convinced this is the best possible definition ... we would have seen more

Re: [libvirt] [PATCHv2 3/5] S390: QEMU driver support for CCW addresses

2013-02-11 Thread Daniel P. Berrange
To clarify my earlier reply - my point is that in the following method: On Fri, Feb 08, 2013 at 06:32:22PM +0100, Viktor Mihajlovski wrote: +/* + * Three steps populating CCW devnos + * 1. Allocate empty address set + * 2. Gather addresses with explicit devno + * 3. Assign defaults to the

Re: [libvirt] [PATCHv2 3/5] S390: QEMU driver support for CCW addresses

2013-02-11 Thread Viktor Mihajlovski
On 02/11/2013 06:41 PM, Daniel P. Berrange wrote: To clarify my earlier reply - my point is that in the following method: Thanks Daniel ... no clarification needed here. :-) -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development GmbH

[libvirt] [PATCHv2 3/5] S390: QEMU driver support for CCW addresses

2013-02-08 Thread Viktor Mihajlovski
This commit adds the QEMU driver support for CCW addresses. The current QEMU only allows virtio devices to be attached to the CCW bus. We named the new capability indicating that support QEMU_CAPS_VIRTIO_CCW accordingly. The fact that CCW devices can only be assigned to domains with a machine