Re: [libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling?for -blockdev

2023-10-16 Thread Peter Krempa
On Mon, Oct 16, 2023 at 14:19:08 +, Chun Feng Wu wrote: > Thanks for your info! Currently, the iotune in libvirt’s xml indeed works > well, BTW, is there any plan for such “re-engineering”? No, there are no plans, as the current approach covers the vast majority of use cases. Spending signifi

RE: [libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling for -blockdev

2023-10-16 Thread Chun Feng Wu
: process: Setup disk io throttling for -blockdev On Mon, Oct 16, 2023 at 13:36:42 +, Chun Feng Wu wrote: > Does this libvirt throttling support “chained throttle filters” for single > disk described in QEMU doc: > https://github.com/qemu/qemu/blob/master/docs/throttle.txt (“The

Re: [libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling for -blockdev

2023-10-16 Thread Peter Krempa
On Mon, Oct 16, 2023 at 13:36:42 +, Chun Feng Wu wrote: > Does this libvirt throttling support “chained throttle filters” for single > disk described in QEMU doc: > https://github.com/qemu/qemu/blob/master/docs/throttle.txt (“The 'throttle' > block filter”) No, libvirt currently still uses

[libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling for -blockdev

2023-10-16 Thread Chun Feng Wu
Does this libvirt throttling support “chained throttle filters” for single disk described in QEMU doc: https://github.com/qemu/qemu/blob/master/docs/throttle.txt (“The 'throttle' block filter”)

Re: [libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling for -blockdev

2018-08-16 Thread Ján Tomko
On Mon, Aug 13, 2018 at 06:00:11PM +0200, Peter Krempa wrote: The proper way to do this would be to use the 'throttle' driver but unfortunately it can't change the 'throttle_group' so we can't provide feature parity. This hack uses the block_set_io_throttle command to do so until we can properly

[libvirt] [PATCHv2 37/62] qemu: process: Setup disk io throttling for -blockdev

2018-08-13 Thread Peter Krempa
The proper way to do this would be to use the 'throttle' driver but unfortunately it can't change the 'throttle_group' so we can't provide feature parity. This hack uses the block_set_io_throttle command to do so until we can properly replace it. Signed-off-by: Peter Krempa --- src/qemu/qemu_pro