[libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Peter Krempa
This patch improves the error message after disconnecting from the hypervisor and adds the close callback operations required not to leak the callback reference. --- tools/virsh.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Viktor Mihajlovski
On 03/27/2013 03:05 PM, Peter Krempa wrote: This patch improves the error message after disconnecting from the hypervisor and adds the close callback operations required not to leak the callback reference. --- tools/virsh.c | 23 +-- 1 file changed, 17 insertions(+), 6

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Peter Krempa
On 03/27/13 16:00, Viktor Mihajlovski wrote: On 03/27/2013 03:05 PM, Peter Krempa wrote: This patch improves the error message after disconnecting from the hypervisor and adds the close callback operations required not to leak the callback reference. --- tools/virsh.c | 23

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Peter Krempa
On 03/27/13 16:05, Peter Krempa wrote: On 03/27/13 16:00, Viktor Mihajlovski wrote: On 03/27/2013 03:05 PM, Peter Krempa wrote: This patch improves the error message after disconnecting from the hypervisor and adds the close callback operations required not to leak the callback reference. ---

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Viktor Mihajlovski
On 03/27/2013 04:13 PM, Peter Krempa wrote: I've re-run the test suite and I'm not getting any errors. I have the current upstream (including your 2/3 patch from v1) and these four on top. What tests are failing for you? Peter After taking out 1/3 I don't get the errors, which is logical,

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Peter Krempa
On 03/27/13 16:26, Viktor Mihajlovski wrote: On 03/27/2013 04:13 PM, Peter Krempa wrote: I've re-run the test suite and I'm not getting any errors. I have the current upstream (including your 2/3 patch from v1) and these four on top. What tests are failing for you? Peter After taking out

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect

2013-03-27 Thread Viktor Mihajlovski
On 03/27/2013 04:32 PM, Peter Krempa wrote: My tree actually contains 1/3 from your v1 series and I also reposted it in my v2 and I don't seem to be getting errors when I have the 4 (5 with the one pushed upstream) patches applied. Peter Never mind and sorry. It seems that I was tricked by