Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-12 Thread Eric Blake
On 08/09/2013 10:20 PM, Doug Goldstein wrote: I can ACK this by visual code inspection. I haven't explicitly tested this patch but its a cleaned up version of the patch we previously discussed it. If you need me to test it, I can do that tonight. I'd feel better with an explicit test; we're

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Eric Blake
On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Daniel P. Berrange
On Fri, Aug 09, 2013 at 09:31:39AM -0600, Eric Blake wrote: On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-09 Thread Doug Goldstein
On Fri, Aug 9, 2013 at 10:31 AM, Eric Blake ebl...@redhat.com wrote: On 08/07/2013 08:15 AM, Eric Blake wrote: On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-07 Thread Doug Goldstein
On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were unconditionally initializing gcrypt even when gnutls wouldn't be

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-07 Thread Eric Blake
On 08/07/2013 07:29 AM, Doug Goldstein wrote: On Tue, Jul 30, 2013 at 3:45 PM, Eric Blake ebl...@redhat.com wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were unconditionally

Re: [libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-08-06 Thread Eric Blake
ping On 07/30/2013 02:45 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were unconditionally initializing gcrypt even when gnutls wouldn't be using it, and having

[libvirt] [PATCHv3] build: avoid -lgcrypt with newer gnutls

2013-07-30 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=951637 Newer gnutls uses nettle, rather than gcrypt, which is a lot nicer regarding initialization. Yet we were unconditionally initializing gcrypt even when gnutls wouldn't be using it, and having two crypto libraries linked into libvirt.so is