Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-08-01 Thread Eric Blake
On 07/31/2011 09:00 PM, Wen Congyang wrote: > At 07/30/2011 05:32 AM, Eric Blake Write: >> Currently, we attempt to run sync job and async job at the same time. It >> means that the monitor commands for two jobs can be run in any order. >> >> >> v3: incorporate Wen's feedback - in particular, virPr

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-08-01 Thread Eric Blake
On 07/29/2011 08:53 PM, Wen Congyang wrote: > At 07/30/2011 05:37 AM, Eric Blake write: >> On 07/29/2011 03:32 PM, Eric Blake wrote: >>> Currently, we attempt to run sync job and async job at the same time. It >>> means that the monitor commands for two jobs can be run in any order. >>> >> >>> >>>

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-07-31 Thread Wen Congyang
At 07/30/2011 05:32 AM, Eric Blake Write: > Currently, we attempt to run sync job and async job at the same time. It > means that the monitor commands for two jobs can be run in any order. > > In the function qemuDomainObjEnterMonitorInternal(): > if (priv->job.active == QEMU_JOB_NONE && priv-

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Wen Congyang
At 07/30/2011 05:37 AM, Eric Blake write: On 07/29/2011 03:32 PM, Eric Blake wrote: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. v3: incorporate Wen's feedback - in particular, virProcessStartC

Re: [libvirt] [PATCHv3] qemu: fix crash when mixing sync and async monitor jobs

2011-07-29 Thread Eric Blake
On 07/29/2011 03:32 PM, Eric Blake wrote: Currently, we attempt to run sync job and async job at the same time. It means that the monitor commands for two jobs can be run in any order. v3: incorporate Wen's feedback - in particular, virProcessStartCPUs now checks for return type, restarting