Re: [libvirt] [PATCHv3 3/3] util: netlink: Using virNetlinkNewLink to simplify virNetDev*Create

2018-09-10 Thread Shi Lei
On 2018-09-10 at 22:39, Erik Skultety wrote: >On Fri, Sep 07, 2018 at 03:17:26PM +0800, Shi Lei wrote: >> This patch simplifies virNetDevBridgeCreate and virNetDevMacVLanCreate >> by using virNetlinkNewLink. >> >> Signed-off-by: Shi Lei >> --- > >I'll make a tiny cosmetic change to the commit

Re: [libvirt] [PATCHv3 3/3] util: netlink: Using virNetlinkNewLink to simplify virNetDev*Create

2018-09-10 Thread Erik Skultety
On Fri, Sep 07, 2018 at 03:17:26PM +0800, Shi Lei wrote: > This patch simplifies virNetDevBridgeCreate and virNetDevMacVLanCreate > by using virNetlinkNewLink. > > Signed-off-by: Shi Lei > --- I'll make a tiny cosmetic change to the commit message before merging. Reviewed-by: Erik Skultety --

[libvirt] [PATCHv3 3/3] util: netlink: Using virNetlinkNewLink to simplify virNetDev*Create

2018-09-07 Thread Shi Lei
This patch simplifies virNetDevBridgeCreate and virNetDevMacVLanCreate by using virNetlinkNewLink. Signed-off-by: Shi Lei --- src/util/virnetdevbridge.c | 73 +++- src/util/virnetdevmacvlan.c | 110 +--- 2 files changed, 24 insertions(+),